[PATCH] D77710: [MLIR] ShapedType accessor minor fixes + add isDynamicDim accessor

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 12:30:31 PDT 2020


nicolasvasilache added a comment.

`Can we initialize it to kDynamicSize instead of hardcoded -1?`

Orthogonally to this revision, note that this is a particular pain point: there are a lot of `-1` scattered around the codebase both in MLIR and things that depend on MLIR.
-1 is not good enough for representing dynamic offset and strides.
I had started an effort to clean that up a few months ago but did not see the light at the end of the tunnel..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77710/new/

https://reviews.llvm.org/D77710





More information about the llvm-commits mailing list