[llvm] 0605f5f - unittest: Disable MachineInstrClone.CopyCallSiteInfo entirely

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 12:18:40 PDT 2020


Author: Vedant Kumar
Date: 2020-04-08T12:16:22-07:00
New Revision: 0605f5fbe755326e3dbc8daa4fc34453b8c5ac0e

URL: https://github.com/llvm/llvm-project/commit/0605f5fbe755326e3dbc8daa4fc34453b8c5ac0e
DIFF: https://github.com/llvm/llvm-project/commit/0605f5fbe755326e3dbc8daa4fc34453b8c5ac0e.diff

LOG: unittest: Disable MachineInstrClone.CopyCallSiteInfo entirely

Somehow, details about the host architecture are creeping into the bogus
target set up in MFCommon.inc, causing call site info to be disabled:

http://lab.llvm.org:8011/builders/lld-x86_64-win7/builds/41476
http://lab.llvm.org:8011/builders/clang-s390x-linux-lnt/builds/17987

Disable the test to unblock the bots until I can figure this out.

Added: 
    

Modified: 
    llvm/unittests/CodeGen/MachineInstrTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/CodeGen/MachineInstrTest.cpp b/llvm/unittests/CodeGen/MachineInstrTest.cpp
index cb94edabfed5..33baaf62efdf 100644
--- a/llvm/unittests/CodeGen/MachineInstrTest.cpp
+++ b/llvm/unittests/CodeGen/MachineInstrTest.cpp
@@ -383,30 +383,6 @@ TEST(MachineInstrExtraInfo, RemoveExtraInfo) {
   ASSERT_FALSE(MI->getHeapAllocMarker());
 }
 
-#ifndef _WIN32
-// See discussion on https://reviews.llvm.org/D77685, this is throwing a SEH
-// exception when run on a Windows bot despite being UBSan-clean.
-TEST(MachineInstrClone, CopyCallSiteInfo) {
-  LLVMContext Ctx;
-  Module Mod("Module", Ctx);
-  auto MF = createMachineFunction(Ctx, Mod);
-  auto MBB = MF->CreateMachineBasicBlock();
-  auto MII = MBB->begin();
-
-  MCInstrDesc MCID = {0, 0,       0,       0,      0, (1ULL << MCID::Call),
-                      0, nullptr, nullptr, nullptr};
-
-  MachineFunction::CallSiteInfo CSInfo;
-  auto MI = MF->CreateMachineInstr(MCID, DebugLoc());
-  ASSERT_TRUE(MI->isCandidateForCallSiteEntry());
-  MBB->insert(MII, MI);
-  MF->addCallArgsForwardingRegs(MI, std::move(CSInfo));
-  EXPECT_EQ(MF->getCallSitesInfo().size(), 1u);
-  MF->CloneMachineInstrBundle(*MBB, MBB->end(), *MI);
-  EXPECT_EQ(MF->getCallSitesInfo().size(), 2u);
-}
-#endif
-
 static_assert(is_trivially_copyable<MCOperand>::value, "trivially copyable");
 
 } // end namespace


        


More information about the llvm-commits mailing list