[PATCH] D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 09:45:14 PDT 2020


ldionne created this revision.
Herald added subscribers: llvm-commits, dexonsmith, jkorous, mgorny.
Herald added a project: LLVM.
ldionne added a reviewer: smeenai.
ldionne added a comment.

Not sure who to add -- I'm sending an email to the list with a link to this review.


As discussed in http://lists.llvm.org/pipermail/llvm-dev/2020-March/140349.html,
the minimum version of CMake required to build LLVM will be upgraded to
3.13.4 right after we create the release branch for LLVM 11.0.0.

As part of this effort, this commit adds a warning to give a heads up
to folks regarding the upcoming upgrade. This should allow users to
upgrade their CMake in advance so that the upgrade can sail right
through when the time comes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77740

Files:
  llvm/CMakeLists.txt


Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -2,6 +2,15 @@
 
 cmake_minimum_required(VERSION 3.4.3)
 
+if ("${CMAKE_VERSION}" VERSION_LESS "3.13.4")
+  message(WARNING
+    "The current CMake version is ${CMAKE_VERSION}. As soon as the release "
+    "branch for LLVM 11.0.0 is created, the minimum version of CMake required "
+    "to build LLVM will become 3.13.4, and using an older CMake will become "
+    "an error. Please upgrade your CMake to at least 3.13.4 now to avoid issues "
+    "in the future!")
+endif()
+
 if(POLICY CMP0068)
   cmake_policy(SET CMP0068 NEW)
   set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77740.256046.patch
Type: text/x-patch
Size: 722 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200408/e69e6e32/attachment.bin>


More information about the llvm-commits mailing list