[PATCH] D77634: [MLIR] Support for taskwait and taskyield operations, and translating the same to LLVM IR

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:56
+  let parser = [{ return success(); }];
+  let printer = [{ p << getOperationName(); }];
+}
----------------
kiranktp wrote:
> mehdi_amini wrote:
> > The declarative assembly syntax may be shorter here :)
> Did you mean, this declarative syntax is too short here. Could you please elaborate a bit on this?
Sorry I was terse, I meant to use a different mechanism here possibly, look the section about « Declarative Assembly Format» here : https://mlir.llvm.org/docs/OpDefinitions/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77634/new/

https://reviews.llvm.org/D77634