[PATCH] D77677: [RDA] Don't explicitly store outgoing reaching defs (NFCI)
Sam Parker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 8 08:07:51 PDT 2020
samparker added inline comments.
================
Comment at: lib/CodeGen/ReachingDefAnalysis.cpp:98
// Find the most recent reaching definition from a predecessor.
- for (unsigned Unit = 0; Unit != NumRegUnits; ++Unit)
- LiveRegs[Unit] = std::max(LiveRegs[Unit], Incoming[Unit]);
+ int NumInsts = MBBNumInsts[pred->getNumber()];
+ for (unsigned Unit = 0; Unit != NumRegUnits; ++Unit) {
----------------
Maybe now would be a good time to encapsulate these MBB details in their own class, instead of several separate vectors and a vector of vectors?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77677/new/
https://reviews.llvm.org/D77677
More information about the llvm-commits
mailing list