[PATCH] D77730: [llvm-objdump][NFC] MachODump.cpp interface cleanup
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 8 07:03:31 PDT 2020
hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: jhenderson, MaskRay, DiggerLin, jasonliu, daltenty.
Herald added a subscriber: rupprecht.
Herald added a project: LLVM.
Continuing from D77388 <https://reviews.llvm.org/D77388>, this patch moves interface declarations associated with `MachODump.cpp` into the headers corresponding to the file that defines the variable. At the same time, these externs are moved into the `llvm::objdump` namespace. The externs defined in `MachODump.cpp` that are not referenced outside of it are given internal linkage.
This patch does not rename the external functions defined by `MachODump.cpp` that are not clearly named as being specific to Mach-O.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D77730
Files:
llvm/tools/llvm-objdump/MachODump.cpp
llvm/tools/llvm-objdump/MachODump.h
llvm/tools/llvm-objdump/llvm-objdump.cpp
llvm/tools/llvm-objdump/llvm-objdump.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77730.256014.patch
Type: text/x-patch
Size: 13194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200408/4318dc5e/attachment.bin>
More information about the llvm-commits
mailing list