[PATCH] D77635: [LV] Vectorize with FoldTail when Primary Induction is absent

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:333
+  /// Hold the primary induction phi of the vector loop.
+  Value *PrimaryInduction = nullptr;
+
----------------
Ayal wrote:
> fhahn wrote:
> > Maybe include Vector in the name, e.g. VectorInduction, to avoid confusion with Legal's PrimaryInduction
> Agreed. Updated comment and changed name to VectorLoopScalarIV. Sounds better/ok?
> 
> Maybe better to avoid overloading the "PrimaryInduction" name throughout, keeping it with its original meaning only, and use "Canonical" instead.
We are well into bikeshedding territory now, but just one quick question.  VectorLoopScalarIV describes well what this is I think,  but was just wondering that if we refer to this as the canonical IV in comments, should this not be named something with CanonicalIV in it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77635/new/

https://reviews.llvm.org/D77635