[llvm] d2d808d - [llvm-exegesis][NFC] Remove dead code.
Clement Courbet via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 8 05:30:05 PDT 2020
Author: Clement Courbet
Date: 2020-04-08T14:29:26+02:00
New Revision: d2d808d2efa46dc9d430c7cd8ddb30eedc03af46
URL: https://github.com/llvm/llvm-project/commit/d2d808d2efa46dc9d430c7cd8ddb30eedc03af46
DIFF: https://github.com/llvm/llvm-project/commit/d2d808d2efa46dc9d430c7cd8ddb30eedc03af46.diff
LOG: [llvm-exegesis][NFC] Remove dead code.
Added:
Modified:
llvm/tools/llvm-exegesis/lib/PerfHelper.h
llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp
Removed:
################################################################################
diff --git a/llvm/tools/llvm-exegesis/lib/PerfHelper.h b/llvm/tools/llvm-exegesis/lib/PerfHelper.h
index 7f4fb1f345c9..a6a2fc9b9d2d 100644
--- a/llvm/tools/llvm-exegesis/lib/PerfHelper.h
+++ b/llvm/tools/llvm-exegesis/lib/PerfHelper.h
@@ -82,24 +82,6 @@ struct Counter {
#endif
};
-// Helper to measure a list of PerfEvent for a particular function.
-// callback is called for each successful measure (PerfEvent needs to be valid).
-template <typename Function>
-void Measure(
- ArrayRef<PerfEvent> Events,
- const std::function<void(const PerfEvent &Event, int64_t Value)> &Callback,
- Function Fn) {
- for (const auto &Event : Events) {
- if (!Event.valid())
- continue;
- Counter Cnt(Event);
- Cnt.start();
- Fn();
- Cnt.stop();
- Callback(Event, Cnt.read());
- }
-}
-
} // namespace pfm
} // namespace exegesis
} // namespace llvm
diff --git a/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp b/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp
index 5332b84fb482..fa6f05c900b4 100644
--- a/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp
+++ b/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp
@@ -22,21 +22,14 @@ using ::testing::Not;
TEST(PerfHelperTest, FunctionalTest) {
#ifdef HAVE_LIBPFM
ASSERT_FALSE(pfmInitialize());
- const PerfEvent SingleEvent("CYCLES:u");
- const auto &EmptyFn = []() {};
- std::string CallbackEventName;
- std::string CallbackEventNameFullyQualifed;
- int64_t CallbackEventCycles;
- Measure(
- makeArrayRef(SingleEvent),
- [&](const PerfEvent &Event, int64_t Value) {
- CallbackEventName = std::string(Event.name());
- CallbackEventNameFullyQualifed = std::string(Event.getPfmEventString());
- CallbackEventCycles = Value;
- },
- EmptyFn);
- EXPECT_EQ(CallbackEventName, "CYCLES:u");
- EXPECT_THAT(CallbackEventNameFullyQualifed, Not(IsEmpty()));
+ const PerfEvent Event("CYCLES:u");
+ ASSERT_TRUE(Event.valid());
+ EXPECT_EQ(Event.name(), "CYCLES:u");
+ EXPECT_THAT(Event.getPfmEventString(), Not(IsEmpty()));
+ Counter Cnt(Event);
+ Cnt.start();
+ Cnt.stop();
+ Cnt.read();
pfmTerminate();
#else
ASSERT_TRUE(pfmInitialize());
More information about the llvm-commits
mailing list