[PATCH] D77659: [ELF][test] Add reproduce test for dependent libraries

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lld/test/ELF/reproduce-deplibs.s:12
+# RUN: ld.lld bar.o -o /dev/null --reproduce repro.tar
+# RUN: tar xf repro.tar
+# RUN: cmp foo.a repro/%:t.dir/foo.a
----------------
andrewng wrote:
> grimar wrote:
> > jhenderson wrote:
> > > Idle musing, feel free to ignore: I wonder whether we really need to check that the archive in the tar file is binary identical to the input one? Would just checking that the file is in the package be sufficient?
> > I also wonder about it.
> > 
> > Our `reproduce-windows.s` has:
> > ```
> > # RUN: tar tf repro.tar | FileCheck %s
> > 
> > # CHECK: repro/response.txt
> > # CHECK: repro/{{.*}}/build/foo.o
> > ```
> I've basically followed the convention of the other reproduce tests (except the Windows specific ones) that all check the contents too. I'm guessing this is just to be sure that it's also the correct file. I'm happy to change it to only test for its presence in the TAR file if that's the consensus.
I don't really have an opinion either way. Happy to defer to others on this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77659/new/

https://reviews.llvm.org/D77659