[PATCH] D77709: [MLIR] Add missing colon after CHECKs.

Christian Sigg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 02:40:20 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG06ddb7946bb1: [MLIR] Add missing colon after CHECKs. (authored by csigg).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77709/new/

https://reviews.llvm.org/D77709

Files:
  mlir/test/IR/memory-ops.mlir
  mlir/test/Target/llvmir.mlir
  mlir/test/Transforms/canonicalize.mlir
  mlir/test/Transforms/memref-bound-check.mlir
  mlir/test/Transforms/pipeline-data-transfer.mlir
  mlir/test/mlir-tblgen/pattern.mlir


Index: mlir/test/mlir-tblgen/pattern.mlir
===================================================================
--- mlir/test/mlir-tblgen/pattern.mlir
+++ mlir/test/mlir-tblgen/pattern.mlir
@@ -32,7 +32,7 @@
   return
 }
 
-// CHECK-LABEL verifyZeroArg
+// CHECK-LABEL: verifyZeroArg
 func @verifyZeroArg() -> i32 {
   // CHECK: "test.op_k"() : () -> i32
   %0 = "test.op_j"() : () -> i32
Index: mlir/test/Transforms/pipeline-data-transfer.mlir
===================================================================
--- mlir/test/Transforms/pipeline-data-transfer.mlir
+++ mlir/test/Transforms/pipeline-data-transfer.mlir
@@ -136,7 +136,7 @@
     // CHECK: [[TAG_ARG1:%[0-9]+]] = alloc() : memref<2x2xi32>
     // CHECK: affine.dma_start %{{.*}}[
     // CHECK: affine.dma_start %{{.*}}[
-    // CHECK-NEXT affine.for %{{.*}} = 1 to 8 {
+    // CHECK-NEXT: affine.for %{{.*}} = 1 to 8 {
     affine.for %i1 = 0 to 8 {
       %7 = affine.apply #map1(%i0, %i1)
       %8 = affine.apply #map2(%i1)
Index: mlir/test/Transforms/memref-bound-check.mlir
===================================================================
--- mlir/test/Transforms/memref-bound-check.mlir
+++ mlir/test/Transforms/memref-bound-check.mlir
@@ -56,8 +56,8 @@
       %idy1 = affine.apply affine_map<(d0, d1, d2) -> (d1 floordiv 4)>(%i, %j, %j)
       %idy2 = affine.apply affine_map<(d0, d1, d2) -> (d2 ceildiv 4 - 1)>(%i, %j, %j)
       affine.store %x, %A[%idy0, %idy1, %idy2] : memref<128 x 64 x 64 x i32> // expected-error {{'affine.store' op memref out of lower bound access along dimension #3}}
-    } // CHECK }
-  } // CHECK }
+    } // CHECK: }
+  } // CHECK: }
   return
 }
 
@@ -82,7 +82,7 @@
       %x  = affine.load %A[%idx0, %zero] : memref<257 x 256 x i32>
       %idy = affine.apply affine_map<(d0, d1) -> (d0 floordiv 256)>(%i, %i)
       %y  = affine.load %B[%idy] : memref<1 x i32>
-    } // CHECK-NEXT }
+    } // CHECK-NEXT: }
   }
   return
 }
Index: mlir/test/Transforms/canonicalize.mlir
===================================================================
--- mlir/test/Transforms/canonicalize.mlir
+++ mlir/test/Transforms/canonicalize.mlir
@@ -370,7 +370,7 @@
 
 // CHECK-LABEL: func @dead_block_elim
 func @dead_block_elim() {
-  // CHECK-NOT ^bb
+  // CHECK-NOT: ^bb
   func @nested() {
     return
 
Index: mlir/test/Target/llvmir.mlir
===================================================================
--- mlir/test/Target/llvmir.mlir
+++ mlir/test/Target/llvmir.mlir
@@ -1202,7 +1202,7 @@
   llvm.return
 }
 
-// CHECK-LABEL @passthrough
+// CHECK-LABEL: @passthrough
 // CHECK: #[[ATTR_GROUP:[0-9]*]]
 llvm.func @passthrough() attributes {passthrough = ["noinline", ["alignstack", "4"], "null-pointer-is-valid", ["foo", "bar"]]} {
   llvm.return
Index: mlir/test/IR/memory-ops.mlir
===================================================================
--- mlir/test/IR/memory-ops.mlir
+++ mlir/test/IR/memory-ops.mlir
@@ -111,8 +111,8 @@
   // DMA with strides
   dma_start %A[%c0], %Ah[%c0], %num_elements, %tag[%c0], %stride, %elt_per_stride : memref<256 x f32>, memref<256 x f32, 1>, memref<1 x f32>
   dma_wait %tag[%c0], %num_elements : memref<1 x f32>
-  // CHECK-NEXT  dma_start %0[%c0], %1[%c0], %c256, %2[%c0], %c32, %c16 : memref<256xf32>, memref<256xf32, 1>, memref<1xf32>
-  // CHECK-NEXT  dma_wait %2[%c0], %c256 : memref<1xf32>
+  // CHECK-NEXT:  dma_start %0[%c0], %1[%c0], %c256, %2[%c0], %c32, %c16 : memref<256xf32>, memref<256xf32, 1>, memref<1xf32>
+  // CHECK-NEXT:  dma_wait %2[%c0], %c256 : memref<1xf32>
 
   return
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77709.255934.patch
Type: text/x-patch
Size: 3540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200408/84302808/attachment.bin>


More information about the llvm-commits mailing list