[PATCH] D77710: [MLIR] ShapedType accessor minor fixes + add isDynamicDim accessor

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 02:07:51 PDT 2020


ftynse accepted this revision.
ftynse added inline comments.


================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:1071
   auto opType = memrefOrTensor().getType();
-  int64_t indexSize = -1;
+  int64_t dimSize = -1;
   if (auto tensorType = opType.dyn_cast<RankedTensorType>())
----------------
Can we initialize it to kDynamicSize instead of hardcoded -1?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77710/new/

https://reviews.llvm.org/D77710





More information about the llvm-commits mailing list