[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Apr  8 01:02:50 PDT 2020
    
    
  
jhenderson added a comment.
My impression is that you shouldn't be making changes in code you are not already familiar with without a review, even if the fix seems fairly obvious (it's surprising how often an "obvious" fix isn't actually the right thing to do). I'd have assumed this was covered by "any uncertainty" already. Presumably to get familiarity with said area of code, you'd already have prior art in getting/giving reviews of a given area, so would know the local culture?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77683/new/
https://reviews.llvm.org/D77683
    
    
More information about the llvm-commits
mailing list