[PATCH] D77580: [llvm-objdump] Fix incomplete relocation output for -D -r mode

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1591
+            // is not the complete data, and we would see relocation prints in
+            // the middle of the complete data. But this matches the binutils
+            // objdump output.
----------------
hubert.reinterpretcast wrote:
> s/. But this matches/, but this is what matches/;
Actually, I think "but this matches" is a better phrasing (but should be part of the sentence before as you suggest). I'd also use a colon rather than a full stop for the end of the "Note..." bit. I'd recommend the following, with some other minor rewording too:

"... is not the complete data: we might see the relocation printed in the middle of the data, but this matches the binutils objdump output."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77580/new/

https://reviews.llvm.org/D77580