[PATCH] D77700: [VE] Simplify definitions of uimm6 and simm7
Simon Moll via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 8 00:29:57 PDT 2020
simoll added a comment.
Good catch!
Minor nit. Otw, LGTM.
================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:29
+def uimm6 : Operand<i32>, PatLeaf<(imm), [{
+ return isUInt<6>(N->getZExtValue()); }]>;
+
----------------
How come there is a `DecoderMethod` for `simm7` but not for `uimm6`? I am not saying this is wrong but i'd like to understand why this works.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77700/new/
https://reviews.llvm.org/D77700
More information about the llvm-commits
mailing list