[PATCH] D77693: [AMDGPU] Expand vector trunc stores from i16 to i8

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

In D77693#1968350 <https://reviews.llvm.org/D77693#1968350>, @rampitec wrote:

> In D77693#1968323 <https://reviews.llvm.org/D77693#1968323>, @arsenm wrote:
>
> > Can merge with the existing store tests
>
>
> Which file do you prefer?




In D77693#1968400 <https://reviews.llvm.org/D77693#1968400>, @rampitec wrote:

> In D77693#1968350 <https://reviews.llvm.org/D77693#1968350>, @rampitec wrote:
>
> > In D77693#1968323 <https://reviews.llvm.org/D77693#1968323>, @arsenm wrote:
> >
> > > Can merge with the existing store tests
> >
> >
> > Which file do you prefer?
>
>
> In fact that was long annoying me, we have many tests with zillions of functions. When I need to debug I first have to find which function has failed, then extract it.
>
> I understand that we do not want to have a billion of files, but really a number of failures does not tell much anymore and a four or even five digit line number within a test usually discourages.
>
> I know it is not only me, after all that is why we have all that update* scripts. Then we update a huge test and I refuse to believe everybody really looks to all the changes. We are saving on forks, but we are loosing in test quality I suppose.


Some of the older tests, like load and store, are not consistent enough. Ideally we would have tests for all of the types of loads for every address space (possibly generated)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77693/new/

https://reviews.llvm.org/D77693