[PATCH] D77707: [mlir] Eliminate the remaining usages of cl::opt instead of PassOption.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 7 22:52:23 PDT 2020


rriddle created this revision.
rriddle added a reviewer: mehdi_amini.
Herald added subscribers: llvm-commits, grosul1, bader, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, zzheng, eraman.
Herald added a reviewer: mravishankar.
Herald added a reviewer: antiagainst.
Herald added a reviewer: nicolasvasilache.
Herald added a reviewer: herhut.
Herald added a reviewer: aartbik.
Herald added a project: LLVM.

Pass options are a better choice for various reasons and avoid the need for static constructors.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77707

Files:
  llvm/include/llvm/Support/CommandLine.h
  mlir/include/mlir/Dialect/Affine/Passes.td
  mlir/include/mlir/IR/OperationSupport.h
  mlir/include/mlir/Pass/PassOptions.h
  mlir/include/mlir/Transforms/Passes.td
  mlir/lib/Conversion/LoopsToGPU/LoopsToGPUPass.cpp
  mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp
  mlir/lib/Dialect/Affine/Transforms/LoopTiling.cpp
  mlir/lib/Dialect/Affine/Transforms/LoopUnroll.cpp
  mlir/lib/Dialect/Affine/Transforms/LoopUnrollAndJam.cpp
  mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp
  mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
  mlir/lib/IR/AsmPrinter.cpp
  mlir/lib/Transforms/Inliner.cpp
  mlir/lib/Transforms/LoopFusion.cpp
  mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
  mlir/lib/Transforms/ViewOpGraph.cpp
  mlir/test/Dialect/Affine/affine-data-copy.mlir
  mlir/test/Dialect/Affine/dma-generate.mlir
  mlir/test/Dialect/Affine/inlining.mlir
  mlir/test/Dialect/Affine/loop-tiling.mlir
  mlir/test/Dialect/Affine/unroll-jam.mlir
  mlir/test/Dialect/Affine/unroll.mlir
  mlir/test/Dialect/SPIRV/Transforms/inlining.mlir
  mlir/test/Transforms/inlining.mlir
  mlir/test/Transforms/loop-fusion.mlir
  mlir/test/lib/Pass/TestPassManager.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77707.255901.patch
Type: text/x-patch
Size: 54950 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200408/3d1d4fb6/attachment.bin>


More information about the llvm-commits mailing list