[PATCH] D77686: [mlir][AsmFormat] Avoid invalidating the iterator when verifying attributes
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 7 15:49:49 PDT 2020
mehdi_amini accepted this revision.
mehdi_amini added inline comments.
This revision is now accepted and ready to land.
================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:1416
- iteratorStack.emplace_back(elements.begin(), elements.end());
- break;
- }
----------------
Refactoring and "functional" for is so often better :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77686/new/
https://reviews.llvm.org/D77686
More information about the llvm-commits
mailing list