[PATCH] D77685: MachineFunction: Copy call site info when duplicating insts

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 7 15:49:45 PDT 2020


vsk created this revision.
vsk added reviewers: aprantl, djtodoro, dstenb.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

Preserve call site info for duplicated instructions. We copy over the
call site info in CloneMachineInstrBundle to avoid repeated calls to
copyCallSiteInfo in CloneMachineInstr.

(Alternatively, we could copy call site info higher up the stack, e.g.
into TargetInstrInfo::duplicate, or even into individual backend passes.
However, I don't see how that would be safer or more general than the
current approach.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77685

Files:
  llvm/lib/CodeGen/MachineFunction.cpp
  llvm/test/CodeGen/X86/taildup-callsiteinfo.mir
  llvm/unittests/CodeGen/MFCommon.inc
  llvm/unittests/CodeGen/MachineInstrTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77685.255840.patch
Type: text/x-patch
Size: 5145 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200407/3c9e96ec/attachment.bin>


More information about the llvm-commits mailing list