[PATCH] D77643: Keep output file after successful execution of mlir-opt

[Lukas Sommer via Phabricator via llvm-commits]

LukasSommerTu marked 4 inline comments as done.
LukasSommerTu added a comment.

@mehdi_amini: I do not have commit access, could you please commit the revision for me?



================
Comment at: mlir/examples/standalone/standalone-opt/standalone-opt.cpp:49
 
+static llvm::cl::opt<bool> allowUnregisteredDialects(
+    "allow-unregistered-dialect",
----------------
Kayjukh wrote:
> LukasSommerTu wrote:
> > Kayjukh wrote:
> > > Should this be part of a separate patch? It is not really related to your proposed change.
> > I can make a separate patch for that, but then we would need to pass a magic constant `true` or `false` to `MlirOptMain`, to match the number of required parameters. 
> > 
> > But if you prefer to have that in a separate patch, I can extract it. What do you prefer?
> I was thinking about making a patch for this command line argument first, and then adding the call to `keep`. At least I would update the title and description to mention these changes.
I've updated the description to state the changes to `standalone-opt` more clearly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77643/new/

https://reviews.llvm.org/D77643