[PATCH] D77649: [mlir][DRR] Add location directive

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/docs/DeclarativeRewrites.md:677
+
+`location` must be used as the last argument to an op creation. For example,
+
----------------
Why the last argument? May be weird to come from the C++ world where it is always the first argument.


================
Comment at: mlir/docs/DeclarativeRewrites.md:684
+
+In the above pattern, the generated `LocDst2Op` will use the matched the
+location of `LocSrc2Op` while the root `LocDst1Op` node will still use the fused
----------------
nit: typo `the matched the location`


================
Comment at: mlir/tools/mlir-tblgen/RewriterGen.cpp:696
+    for (int i = 0, e = tree.getNumArgs(); i != e; ++i) {
+      os << (i ? ", " : "") << lookUpArgLoc(i);
+    }
----------------
nit: Remove trivial braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77649/new/

https://reviews.llvm.org/D77649