[PATCH] D77659: [ELF][test] Add reproduce test for dependent libraries
Andrew Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 7 11:23:19 PDT 2020
andrewng marked 2 inline comments as done.
andrewng added inline comments.
================
Comment at: lld/test/ELF/reproduce-deplibs.s:13
+# RUN: tar xf repro.tar
+# RUN: diff foo.a repro/%:t.dir/foo.a
+
----------------
MaskRay wrote:
> `cmp` may be better for comparison between binary files.
The other reproduce tests make use of `diff`, so I've just followed their lead. However, `cmp` probably is more appropriate for the binary files. Perhaps we should change them all to use `cmp` instead of `diff` where applicable?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77659/new/
https://reviews.llvm.org/D77659
More information about the llvm-commits
mailing list