[PATCH] D77643: Keep output file after successful execution of mlir-opt

Tue Apr 7 09:45:15 PDT 2020

LukasSommerTu added a comment.

In D77643#1967140 <https://reviews.llvm.org/D77643#1967140>, @Kayjukh wrote:

> I think it would make sense to propagate the changes to `mlir-opt` as well.

The changes to `mlir-opt.cpp` propagate the change of the file-management to `mlir-opt`. Or did you refer to something else?

================
Comment at: mlir/examples/standalone/standalone-opt/standalone-opt.cpp:49

+static llvm::cl::opt<bool> allowUnregisteredDialects(
+    "allow-unregistered-dialect",
----------------
Kayjukh wrote:
> Should this be part of a separate patch? It is not really related to your proposed change.
I can make a separate patch for that, but then we would need to pass a magic constant `true` or `false` to `MlirOptMain`, to match the number of required parameters. 

But if you prefer to have that in a separate patch, I can extract it. What do you prefer?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77643/new/

https://reviews.llvm.org/D77643