[PATCH] D77635: [LV] Vectorize with FoldTail when Primary Induction is absent

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

I've applied the patch locally, and I'm a bit confused that `test/Transforms/LoopVectorize/ARM/tail-folding-counting-down.ll` doesn't fail for me, I will double check to see what's going on.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:6772
 
     // Introduce the early-exit compare IV <= BTC to form header block mask.
     // This is used instead of IV < TC because TC may wrap, unlike BTC.
----------------
nit: perhaps this comments now needs to be moved to line 6782, and we need to say something new/extra about the primary IV?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1153
+  VPWidenPrimaryInductionRecipe() : VPRecipeBase(VPWidenPrimaryInductionSC) {
+    Val = new VPValue();
+  }
----------------
nit: just curious, do we actually need this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77635/new/

https://reviews.llvm.org/D77635