[PATCH] D77543: [mlir][spirv] Fix wrong Phi parent block for back-to-back loops

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar accepted this revision.
mravishankar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp:99
+      Operation *op = loopOp.getOperation();
+      while ((op = op->getPrevNode()) != nullptr)
+        if (Block *incomingBlock = getStructuredControlFlowOpMergeBlock(op))
----------------
Just to clarify, this loop executes at most 1 iteration? If so can we avoid having a while loop? That makes it more confusing IMO


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77543/new/

https://reviews.llvm.org/D77543