[PATCH] D75349: [LLD][ELF][ARM] Implement ARM pc-relative relocations for adr and ldr

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 7 06:28:12 PDT 2020


psmith updated this revision to Diff 255656.
psmith added a comment.

Thanks for the suggestions, I've updated the comments in ARM.cpp, I've also tried to align the CHECK so that it would be indented the same way as if we were looking at a raw llvm-objdump output. I've kept the addresses in for the moment as I've put an explanation in the comment that shows how the instruction matches the target. Happy to make further changes if less information is preferred.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75349/new/

https://reviews.llvm.org/D75349

Files:
  lld/ELF/Arch/ARM.cpp
  lld/test/ELF/arm-adr-err.s
  lld/test/ELF/arm-adr-long.s
  lld/test/ELF/arm-adr.s
  lld/test/ELF/arm-ldrlit-err.s
  lld/test/ELF/arm-ldrlit.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75349.255656.patch
Type: text/x-patch
Size: 16428 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200407/9a3d0d0e/attachment.bin>


More information about the llvm-commits mailing list