[llvm] 210f40f - Test had incorrect check for nonzero count

Tue Apr 7 06:26:10 PDT 2020

Hi David,
Sorry for the breakage.  The test works fine for me; can you provide any details about your environment or a link to a bot failure?
In particular, given Petr's statement, do you have the new pass manager on by default?
The test is clearly not verifying what it was supposed to, and if there are environment where it simply doesn't work or additional options that need to be specified to make it not-fail for you, please add the relevant info to PR45459.
Thanks!
--paulr

From: David Zarzycki <dave at znu.io>
Sent: Sunday, April 5, 2020 7:16 AM
To: Petr Hosek <phosek at chromium.org>; Robinson, Paul <paul.robinson at sony.com>
Cc: Paul Robinson via llvm-commits <llvm-commits at lists.llvm.org>
Subject: Re: [llvm] 210f40f - Test had incorrect check for nonzero count

Hi Petr,

I'm about to revert this and fix a couple other weekend breakages. Try again in 10 minutes.

Dave

On Sat, Apr 4, 2020, at 6:07 PM, Petr Hosek via llvm-commits wrote:
We're also seeing the breakage when new pass manager is enabled by default. Can we revert this please?

On Sat, Apr 4, 2020 at 5:21 AM David Zarzycki via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
Hi Paul,

This breaks the first phase of my test bot/script. Can we please revert this? This isn't all of the output, but hopefully what follows is helpful:

BISECT: NOT running pass (152) Stack Slot Coloring on function (f4)
BISECT: NOT running pass (153) Machine Copy Propagation Pass on function (f4)
BISECT: NOT running pass (154) Machine Loop Invariant Code Motion on function (f4)
BISECT: NOT running pass (155) PostRA Machine Sink on function (f4)
BISECT: NOT running pass (156) Shrink Wrapping analysis on function (f4)
BISECT: NOT running pass (157) Control Flow Optimizer on function (f4)
BISECT: NOT running pass (158) Tail Duplication on function (f4)
BISECT: NOT running pass (159) Machine Copy Propagation Pass on function (f4)
BISECT: NOT running pass (160) Post RA top-down list latency scheduler on function (f4)
BISECT: NOT running pass (161) Branch Probability Basic Block Placement on function (f4)
BISECT: NOT running pass (162) X86 Execution Dependency Fix on function (f4)
BISECT: NOT running pass (163) BreakFalseDeps on function (f4)
BISECT: NOT running pass (164) X86 Byte/Word Instruction Fixup on function (f4)
BISECT: NOT running pass (165) X86 Atom pad short functions on function (f4)
BISECT: NOT running pass (166) X86 LEA Fixup on function (f4)
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /tmp/_update_lc/r/bin/FileCheck /home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll --check-prefix=CHECK-BISECT-INLINE-HELPER
/home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll:48:31: error: CHECK-BISECT-INLINE-RESULT: expected string not found in input
; CHECK-BISECT-INLINE-RESULT: Last good count: {{[1-9][0-9]*}}
                              ^
<stdin>:1:1: note: scanning from here
opt: ['/tmp/_update_lc/r/bin/opt', '-O2', '-opt-bisect-limit=128', '-S', '/home/dave/s/lp/llvm/test/Other/opt-bisect-legacy-pass-manager.ll']
^
<stdin>:9:1: note: possible intended match here
Last good count: 0
^

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

10 warning(s) in tests

Testing Time: 156.29s
********************
Failing Tests (1):
    LLVM :: Other/opt-bisect-legacy-pass-manager.ll

  Expected Passes    : 45107
  Expected Failures  : 116
  Unsupported Tests  : 17400
  Unexpected Failures: 1

On Fri, Apr 3, 2020, at 3:37 PM, Paul Robinson via llvm-commits wrote:
>
> Author: Paul Robinson
> Date: 2020-04-03T12:37:13-07:00
> New Revision: 210f40fe9a30212396311d265904b2d73859c53d
>
> URL:
> https://github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d<https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d__;!!JmoZiZGBv3RvKRSx!rU5uT10QRXdCWw_pKu_fqoMjDxMUFI_umhAXh4fGUr8WSYig-dQOjAWODcsOTUE92w$>
> DIFF:
> https://github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d.diff<https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/commit/210f40fe9a30212396311d265904b2d73859c53d.diff__;!!JmoZiZGBv3RvKRSx!rU5uT10QRXdCWw_pKu_fqoMjDxMUFI_umhAXh4fGUr8WSYig-dQOjAWODcvLDAzv5Q$>
>
> LOG: Test had incorrect check for nonzero count
>
> Added:
>
>
> Modified:
>     llvm/test/Other/opt-bisect-legacy-pass-manager.ll
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/llvm/test/Other/opt-bisect-legacy-pass-manager.ll
> b/llvm/test/Other/opt-bisect-legacy-pass-manager.ll
> index bf89e80d4960..d73ca80674da 100644
> --- a/llvm/test/Other/opt-bisect-legacy-pass-manager.ll
> +++ b/llvm/test/Other/opt-bisect-legacy-pass-manager.ll
> @@ -45,8 +45,7 @@
>  ; The helper script uses this to find the optimization that inlines
> the call.
>  ; CHECK-BISECT-INLINE-HELPER: call i32 @f2()
>  ; These checks verifies that the optimization was found.
> -; CHECK-BISECT-INLINE-RESULT-NOT: Last good count: 0
> -; CHECK-BISECT-INLINE-RESULT: Last good count: {{[0-9]+}}
> +; CHECK-BISECT-INLINE-RESULT: Last good count: {{[1-9][0-9]*}}
>
>
>  ; Test a module pass.
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits__;!!JmoZiZGBv3RvKRSx!rU5uT10QRXdCWw_pKu_fqoMjDxMUFI_umhAXh4fGUr8WSYig-dQOjAWODct8tOQr3Q$>
>
_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits__;!!JmoZiZGBv3RvKRSx!rU5uT10QRXdCWw_pKu_fqoMjDxMUFI_umhAXh4fGUr8WSYig-dQOjAWODct8tOQr3Q$>
_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits__;!!JmoZiZGBv3RvKRSx!rU5uT10QRXdCWw_pKu_fqoMjDxMUFI_umhAXh4fGUr8WSYig-dQOjAWODct8tOQr3Q$>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200407/9e6cffb7/attachment.html>