[PATCH] D76305: [RS4GC] Fix algorithm to avoid setting vector BDV for scalar derived pointer

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

>From what I see it should work. The only thing worries me is that this isCorrectType seems to be not incorporated into solution but some side hack to solve the problem.
Unfortunately at this moment I do not have a better suggestion :(

If I understand correctly this is a fix for functional bug, so probably it makes sense to land it in this form.

Let me to thing one day more, if I cannot come up with some proposal I agree on this one.



================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:667
+// Returns true if First and Second values are both scalar or both vector.
+static bool isCorrectType(Value *First, Value *Second) {
+  return isa<VectorType>(First->getType()) ==
----------------
Confusing name...
areTypesMatched? or something like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76305/new/

https://reviews.llvm.org/D76305