[PATCH] D77634: [MLIR] Support for taskwait and taskyield operations, and translating the same to LLVM IR

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:56
+  let parser = [{ return success(); }];
+  let printer = [{ p << getOperationName(); }];
+}
----------------
The declarative assembly syntax may be shorter here :)


================
Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:313
+    return success();
+  }
+  return opInst.emitError("unsupported OpenMP operation: ") << opInst.getName();
----------------
The sequence may be representable with a TypeSwitch here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77634/new/

https://reviews.llvm.org/D77634