[PATCH] D77624: [PowerPC] Update alignment for ReuseLoadInfo in LowerFP_TO_INTForReuse

[Kai Luo via Phabricator via llvm-commits]

lkail updated this revision to Diff 255608.
lkail added a comment.

Discussed with @steven.zhang, it seems more appropriate to use `Align` directly and initialize it to the default alignment of the stored value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77624/new/

https://reviews.llvm.org/D77624

Files:
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/test/CodeGen/PowerPC/kernel-fp-round.ll


Index: llvm/test/CodeGen/PowerPC/kernel-fp-round.ll
===================================================================
--- llvm/test/CodeGen/PowerPC/kernel-fp-round.ll
+++ llvm/test/CodeGen/PowerPC/kernel-fp-round.ll
@@ -6,7 +6,7 @@
 ; CHECK-NEXT:   - { id: 0, size: 4, alignment: 4 }
 ; CHECK:        %2:f8rc = FCTIWZ killed %1, implicit $rm
 ; CHECK:        STFIWX killed %2, $zero8, %3
-; CHECK-NEXT:   %4:f8rc = LFIWAX $zero8, %3 :: (load 4 from %stack.0, align 1)
+; CHECK-NEXT:   %4:f8rc = LFIWAX $zero8, %3 :: (load 4 from %stack.0)
 entry:
   %b = fptosi float %a to i32
   %c = sitofp i32 %b to float
Index: llvm/lib/Target/PowerPC/PPCISelLowering.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCISelLowering.cpp
+++ llvm/lib/Target/PowerPC/PPCISelLowering.cpp
@@ -7919,15 +7919,17 @@
 
   // Emit a store to the stack slot.
   SDValue Chain;
+  Align Alignment(DAG.getEVTAlign(Tmp.getValueType()));
   if (i32Stack) {
     MachineFunction &MF = DAG.getMachineFunction();
+    Alignment = Align(4);
     MachineMemOperand *MMO =
-        MF.getMachineMemOperand(MPI, MachineMemOperand::MOStore, 4, Align(4));
+        MF.getMachineMemOperand(MPI, MachineMemOperand::MOStore, 4, Alignment);
     SDValue Ops[] = { DAG.getEntryNode(), Tmp, FIPtr };
     Chain = DAG.getMemIntrinsicNode(PPCISD::STFIWX, dl,
               DAG.getVTList(MVT::Other), Ops, MVT::i32, MMO);
   } else
-    Chain = DAG.getStore(DAG.getEntryNode(), dl, Tmp, FIPtr, MPI);
+    Chain = DAG.getStore(DAG.getEntryNode(), dl, Tmp, FIPtr, MPI, Alignment);
 
   // Result is a load from the stack slot.  If loading 4 bytes, make sure to
   // add in a bias on big endian.
@@ -7940,6 +7942,7 @@
   RLI.Chain = Chain;
   RLI.Ptr = FIPtr;
   RLI.MPI = MPI;
+  RLI.Alignment = Alignment;
 }
 
 /// Custom lowers floating point to integer conversions to use


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77624.255608.patch
Type: text/x-patch
Size: 1885 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200407/01aae7db/attachment.bin>