[PATCH] D77562: [NFC][XCOFF] refactor readobj/XCOFFDumper.cpp

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. One optional comment from me.



================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:134
+  static constexpr uint8_t SymbolAlignmentMask = 0xF8;
+  static constexpr uint8_t SymbolAlignmentBitOffset = 0x03;
 
----------------
hubert.reinterpretcast wrote:
> Bit offsets are typically not indicated in hex. The type would be normally be `unsigned` or `size_t`.
FWIW, I'd use `size_t` since `sizeof(type)` returns a `size_t`, but I don't think it matters that much.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77562/new/

https://reviews.llvm.org/D77562