[PATCH] D77554: [DWARFDebugLine] Check for (EOF) errors when parsing v5 content descriptors

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I feel like this is slightly undertested: at the moment, you only have one new test case, but there are two other places where a warning can be detected, one of which causes a different code path too (the early out from the loop). I think all three need testing.



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_short_prologue.s:1
+# RUN: llvm-mc -triple x86_64-pc-linux %s -filetype=obj -o %t
+# RUN: llvm-dwarfdump -debug-line %t 2>&1 | FileCheck %s
----------------
This is probably fine as is, but did you consider extending debug_line_invalid.s (and its corresponding input file) or the gtest unit tests to test this?


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_short_prologue.s:36
+.byte   5               # DW_LNCT_MD5
+.Lshort_prologue_header_end1:
+.Lshort_prologue_end1:
----------------
Could you add a comment please, saying why this entry is considered too short?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77554/new/

https://reviews.llvm.org/D77554