[PATCH] D77625: Fix a typo in the error message for an incorrect prototype.

Jean-Luc Brouillet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 20:11:05 PDT 2020


Jean-Luc created this revision.
Herald added subscribers: llvm-commits, grosul1, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.
Jean-Luc added a reviewer: matthiaskramm.

Cut & paste error had the error message mentionning "}" rather than ")".


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77625

Files:
  mlir/examples/toy/Ch1/include/toy/Parser.h
  mlir/examples/toy/Ch2/include/toy/Parser.h
  mlir/examples/toy/Ch3/include/toy/Parser.h
  mlir/examples/toy/Ch4/include/toy/Parser.h
  mlir/examples/toy/Ch5/include/toy/Parser.h
  mlir/examples/toy/Ch6/include/toy/Parser.h
  mlir/examples/toy/Ch7/include/toy/Parser.h


Index: mlir/examples/toy/Ch7/include/toy/Parser.h
===================================================================
--- mlir/examples/toy/Ch7/include/toy/Parser.h
+++ mlir/examples/toy/Ch7/include/toy/Parser.h
@@ -583,7 +583,7 @@
       } while (true);
     }
     if (lexer.getCurToken() != ')')
-      return parseError<PrototypeAST>("}", "to end function prototype");
+      return parseError<PrototypeAST>(")", "to end function prototype");
 
     // success.
     lexer.consume(Token(')'));
Index: mlir/examples/toy/Ch6/include/toy/Parser.h
===================================================================
--- mlir/examples/toy/Ch6/include/toy/Parser.h
+++ mlir/examples/toy/Ch6/include/toy/Parser.h
@@ -428,7 +428,7 @@
       } while (true);
     }
     if (lexer.getCurToken() != ')')
-      return parseError<PrototypeAST>("}", "to end function prototype");
+      return parseError<PrototypeAST>(")", "to end function prototype");
 
     // success.
     lexer.consume(Token(')'));
Index: mlir/examples/toy/Ch5/include/toy/Parser.h
===================================================================
--- mlir/examples/toy/Ch5/include/toy/Parser.h
+++ mlir/examples/toy/Ch5/include/toy/Parser.h
@@ -428,7 +428,7 @@
       } while (true);
     }
     if (lexer.getCurToken() != ')')
-      return parseError<PrototypeAST>("}", "to end function prototype");
+      return parseError<PrototypeAST>(")", "to end function prototype");
 
     // success.
     lexer.consume(Token(')'));
Index: mlir/examples/toy/Ch4/include/toy/Parser.h
===================================================================
--- mlir/examples/toy/Ch4/include/toy/Parser.h
+++ mlir/examples/toy/Ch4/include/toy/Parser.h
@@ -428,7 +428,7 @@
       } while (true);
     }
     if (lexer.getCurToken() != ')')
-      return parseError<PrototypeAST>("}", "to end function prototype");
+      return parseError<PrototypeAST>(")", "to end function prototype");
 
     // success.
     lexer.consume(Token(')'));
Index: mlir/examples/toy/Ch3/include/toy/Parser.h
===================================================================
--- mlir/examples/toy/Ch3/include/toy/Parser.h
+++ mlir/examples/toy/Ch3/include/toy/Parser.h
@@ -428,7 +428,7 @@
       } while (true);
     }
     if (lexer.getCurToken() != ')')
-      return parseError<PrototypeAST>("}", "to end function prototype");
+      return parseError<PrototypeAST>(")", "to end function prototype");
 
     // success.
     lexer.consume(Token(')'));
Index: mlir/examples/toy/Ch2/include/toy/Parser.h
===================================================================
--- mlir/examples/toy/Ch2/include/toy/Parser.h
+++ mlir/examples/toy/Ch2/include/toy/Parser.h
@@ -428,7 +428,7 @@
       } while (true);
     }
     if (lexer.getCurToken() != ')')
-      return parseError<PrototypeAST>("}", "to end function prototype");
+      return parseError<PrototypeAST>(")", "to end function prototype");
 
     // success.
     lexer.consume(Token(')'));
Index: mlir/examples/toy/Ch1/include/toy/Parser.h
===================================================================
--- mlir/examples/toy/Ch1/include/toy/Parser.h
+++ mlir/examples/toy/Ch1/include/toy/Parser.h
@@ -428,7 +428,7 @@
       } while (true);
     }
     if (lexer.getCurToken() != ')')
-      return parseError<PrototypeAST>("}", "to end function prototype");
+      return parseError<PrototypeAST>(")", "to end function prototype");
 
     // success.
     lexer.consume(Token(')'));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77625.255572.patch
Type: text/x-patch
Size: 3486 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200407/383323a9/attachment.bin>


More information about the llvm-commits mailing list