[PATCH] D77164: libclc: Don't pass linker flags to CLC/LLAsm

Mon Apr 6 19:38:39 PDT 2020

jvesely accepted this revision.
jvesely added a comment.
This revision is now accepted and ready to land.

In D77164#1965305 <https://reviews.llvm.org/D77164#1965305>, @daniels wrote:

> In D77164#1958232 <https://reviews.llvm.org/D77164#1958232>, @jvesely wrote:
>
> > Have you tried clearing the target link flags using `set_target_properties(  ... LINK_FLAGS ... )`?
> >  I think having the ability to pass LINK_FLAGS here might be useful in the future.
>
>
> I tried, but the manual says that a) you must use `STATIC_LIBRARY_FLAGS` for static libraries, and b) you must use `STATIC_LIBRARY_OPTIONS` in preference to the former, as it sets rather than appends.
>
> Nevertheless, neither of them actually worked for me, and both continued to pass the machine linker flags.

oh well, it's not like we need any flags now. Thanks for checking.
LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77164/new/

https://reviews.llvm.org/D77164