[PATCH] D77618: [AddressSanitizer] Refactor: Permit >1 interesting operands per instruction

[Jann Horn via Phabricator via llvm-commits]

thejh created this revision.
thejh added a project: LLVM.
Herald added subscribers: llvm-commits, jfb, hiraditya.
thejh edited the summary of this revision.
thejh added a parent revision: D77617: [AddressSanitizer] Split out memory intrinsic handling.
thejh added a child revision: D77619: [AddressSanitizer] Instrument byval call arguments.
thejh edited the summary of this revision.
thejh added reviewers: kcc, glider.

Refactor getInterestingMemoryOperands() so that information about the
pointer operand is returned through an array of structures instead of
passing each piece of information separately by-value.

This is in preparation for returning information about multiple pointer
operands from a single instruction.

A side effect is that, instead of repeatedly generating the same
information through isInterestingMemoryAccess(), it is now simply collected
once and then passed around; that's probably more efficient.

HWAddressSanitizer has a bunch of copypasted code from AddressSanitizer,
so these changes have to be duplicated.

This is patch 3/4 of a patch series:
https://reviews.llvm.org/D77616 [PATCH 1/4] [AddressSanitizer] Refactor ClDebug{Min,Max} handling
https://reviews.llvm.org/D77617 [PATCH 2/4] [AddressSanitizer] Split out memory intrinsic handling
https://reviews.llvm.org/D77618 [PATCH 3/4] [AddressSanitizer] Refactor: Permit >1 interesting operands per instruction
https://reviews.llvm.org/D77619 [PATCH 4/4] [AddressSanitizer] Instrument byval call arguments


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77618

Files:
  llvm/include/llvm/Transforms/Instrumentation/AddressSanitizerCommon.h
  llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
  llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77618.255558.patch
Type: text/x-patch
Size: 26520 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200407/b77359b4/attachment.bin>