[PATCH] D77446: Add MIR-level debugify with only locations support for now

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked 3 inline comments as done.
dsanders added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/Debugify.h:22
+class DIBuilder;
+bool applyDebugifyMetadata(
+    Module &M, iterator_range<Module::iterator> Functions, StringRef Banner,
----------------
vsk wrote:
> Could you please add doxygen for the parameters?
Sure


================
Comment at: llvm/lib/CodeGen/MachineDebugify.cpp:31
+  MachineFunction &MF = MMI.getOrCreateMachineFunction(F);
+  MF.dump();
+
----------------
vsk wrote:
> Is MF.dump() needed?
Oops. I meant to remove that. It's how I confirmed I had the boilerplate working before I started adding the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77446/new/

https://reviews.llvm.org/D77446