[PATCH] D77310: [ms] Add new /PDBSTREAM option to lld-link allowing injection of streams into PDB files.

[Eric Astor via Phabricator via llvm-commits]

epastor marked 2 inline comments as done.
epastor added inline comments.


================
Comment at: lld/COFF/Driver.cpp:1281
+        const std::string file = nameFile.second.str();
+        config->namedStreams[name] = file;
+      }
----------------
thakis wrote:
> epastor wrote:
> > thakis wrote:
> > > Should this do anything if you try to overwrite an existing stream? (Like, error?)
> > I've mimicked other command line flags; the last one with the same name will take precedence.
> I mean, what if this conflicts with a "built-in" pdb named stream (natvis, or what have you)?
Currently, the "built-in" named stream will win. I think that's probably an acceptable outcome.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77310/new/

https://reviews.llvm.org/D77310