[PATCH] D77557: [DWARFDebugLine] Use truncating data extractors for prologue parsing

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:458
+  uint64_t ExpectedEnd = Prologue.TotalLength + Prologue.sizeofTotalLength() -
+                         (Version != 5 ? 2 : 8);
   std::vector<std::string> Errs;
----------------
The version check should be < rather than != here.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:465
+          .str());
   if (Version != 5) {
     Errs.emplace_back("file names table was not null terminated before the end "
----------------
And here, `Version < 5` please.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77557/new/

https://reviews.llvm.org/D77557