[PATCH] D77576: [globalisel] Add lost debug locations verifier
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 6 13:04:47 PDT 2020
vsk added inline comments.
================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fdiv.mir:3
# RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=tahiti -run-pass=legalizer %s -o - | FileCheck -check-prefix=SI %s
+# RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=tahiti -run-pass=mir-debugify,legalizer -mir-debug-loc=0 %s -o - | FileCheck -check-prefix=SI %s
# RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=fiji -run-pass=legalizer %s -o - | FileCheck -check-prefix=VI %s
----------------
arsenm wrote:
> Do we really need to double the number of run lines in every test?
There are some alternatives:
- Get rid of the non-mir debugify check lines. This is fine by me, but some pass authors might not like this.
- Run the tests with `llvm-lit -Dopt='opt -debugify` -Dllc='llc -run-pass=mir-debugify'`. That means only a subset of users/bots are test with debug info.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77576/new/
https://reviews.llvm.org/D77576
More information about the llvm-commits
mailing list