[PATCH] D77360: [mlir][Linalg] Add a linalg.tensor_reshape to operate on tensors

[Lei Zhang via Phabricator via llvm-commits]

antiagainst added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td:140
+  let description = [{
+    The `linalg.reshape` op produces a new tensor whose sizes are a
+    reassociation of the original `src`.
----------------
s/sizes/dimensions/ ?


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td:143
 
-  let extraClassDeclaration = [{
-    static StringRef getReassociationAttrName() { return "reassociation"; }
-    MemRefType getViewType() { return view().getType().cast<MemRefType>(); }
+    A reassociation is defined as a continuous grouping of dimensions and is
+    represented with an affine map array attribute. In the future,
----------------
Nit: I think a reassociation is represented as an affine map attribute and all the reassociations as a whole are represented as the array attribute?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77360/new/

https://reviews.llvm.org/D77360