[PATCH] D77576: [globalisel] Add lost debug locations verifier

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Legalizer.cpp:169
                                    ArrayRef<GISelChangeObserver *> AuxObservers,
+                                   LostDebugLocObserver &LocObserver,
                                    MachineIRBuilder &MIRBuilder) {
----------------
The addition of this argument is rather unfortunate given the AuxObservers list. The reason is the LocObserver needs to be more tightly integrated into the algorithm than most observers. The fewer changes that are made between checkpoints, the more accurately it can detect lossage, particularly given the conservative behaviour for line-0 locations.

In the end I settled on a separate argument over finding the observer within the AuxObservers list as we currently don't have isa/dyn_cast support in observers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77576/new/

https://reviews.llvm.org/D77576