[PATCH] D77258: Clean up usages of asserting vector getters in Type

Mon Apr 6 11:27:35 PDT 2020

efriedma added inline comments.

================
Comment at: mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp:1597
           auto splatAttr = SplatElementsAttr::get(
-              mlir::VectorType::get(
-                  {llvmVectorTy.getUnderlyingType()->getVectorNumElements()},
-                  floatType),
+              mlir::VectorType::get({(unsigned)cast<llvm::VectorType>(
+                                         llvmVectorTy.getUnderlyingType())
----------------
ctetreau wrote:
> sdesmalen wrote:
> > is the cast to `unsigned` needed?
> VectorType::getNumElements() returns uint64_t, where Type::getVectorNumElements() returned unsigned. At least in visual studio, this results in an error due to a narrowing conversion.
> 
> I have no idea why this is, I can't imagine that we'd need 64 bits to express the number of vector lanes.
Actually, I'm pretty sure it's actually "SequentalType::getNumElements()" returns a uint64_t.

We could consider changing that once I land the patch to kill SequentialType.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77258/new/

https://reviews.llvm.org/D77258