[PATCH] D77565: [AArch64] Remove implicit landing pads.

[Momchil Velikov via Phabricator via llvm-commits]

chill added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64BranchTargets.cpp:129
+    // landing could be removed.
+    if (HintNum == 32) {
+      const AArch64Subtarget &Subtarget =
----------------
Suggest using an explicit condition, to spare the reader back-inferencing what conditions could set `HintNum` to 32.


================
Comment at: llvm/lib/Target/AArch64/AArch64BranchTargets.cpp:134
+      if (Subtarget.hasV8_3aOps()) {
+        // PACI[A|B] LR, SP performs the same operation but it is not a landing
+        // pad.
----------------
Why not create the `PACI[AB]` from the very start, with a comment why are we doing it?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77565/new/

https://reviews.llvm.org/D77565