[PATCH] D77525: [mlir][AsmPrinter] Change value numbering for local scope to be the next isolated operation.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 10:51:41 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/include/mlir/IR/Operation.h:608
 inline raw_ostream &operator<<(raw_ostream &os, Operation &op) {
-  op.print(os);
+  op.print(os, OpPrintingFlags().useLocalScope());
   return os;
----------------
bondhugula wrote:
> Did this race condition exist all along (since pass threading) or was it introduced lately? It looks like when pass threading is on, the printing has to always be "isolated from above" op local?
This has always existed, it is only recently that something used it in the common code path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77525/new/

https://reviews.llvm.org/D77525





More information about the llvm-commits mailing list