[PATCH] D77530: [AArch64][GlobalISel] Generalize logic for subregister copies
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 6 10:18:55 PDT 2020
paquette added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/opt-fold-ext-tbz-tbnz.mir:80
; CHECK: liveins: $h0
- ; CHECK: [[SUBREG_TO_REG:%[0-9]+]]:fpr32 = SUBREG_TO_REG 0, $h0, %subreg.hsub
- ; CHECK: %copy:gpr32 = COPY [[SUBREG_TO_REG]]
+ ; CHECK: %copy:gpr32 = COPY $h0
; CHECK: TBNZW %copy, 3, %bb.1
----------------
I don't think this COPY is legal. This is a cross-bank copy from a 16-bit FPR onto a 32-bit GPR.
I think that we need a SUBREG_TO_REG here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77530/new/
https://reviews.llvm.org/D77530
More information about the llvm-commits
mailing list