[PATCH] D77352: [llvm] Fix missing FileCheck directive colons

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 10:18:53 PDT 2020


MaskRay added a comment.

Hi Jonathan,

If you included `Differential Revision: https://reviews.llvm.org/D77352` in the git description, the differential would be closed automatically when the commit landed in master.

Many people agree that the commit description should include `Reviewed-By: ` (not a strict rule). You can find plenty of examples in the history.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77352/new/

https://reviews.llvm.org/D77352





More information about the llvm-commits mailing list