[PATCH] D77511: [RDA] Avoid full reprocessing of blocks in loops (NFCI)

[Nikita Popov via Phabricator via llvm-commits]

nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: lib/CodeGen/ReachingDefAnalysis.cpp:157
+      int Def = Incoming[Unit];
+      if (Def != ReachingDefDefaultVal) {
+        auto Start = MBBReachingDefs[MBBNumber][Unit].begin();
----------------
samparker wrote:
> It would be nice to reduce the indentation and just continue on the inverse. And maybe also continue when MBBReachingDefs[MBBNumber][Unit] is empty instead of comparing iterators below?
I've added the early continue for the `ReachingDefDefaultVal` check. I don't think the same can be done if `MBBReachingDefs[MBBNumber][Unit]` is empty, because we do need to insert a reaching def (and possibly update the end of block reaching def) in that case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77511/new/

https://reviews.llvm.org/D77511