[PATCH] D77562: [NFC][XCOFF] refactor readobj/XCOFFDumper.cpp
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 6 09:45:02 PDT 2020
hubert.reinterpretcast added a comment.
Thanks for doing this.
================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:134
+ static constexpr uint8_t SymbolAlignmentMask = 0xF8;
+ static constexpr uint8_t SymbolAlignmentBitOffset = 0x03;
----------------
Bit offsets are typically not indicated in hex. The type would be normally be `unsigned` or `size_t`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77562/new/
https://reviews.llvm.org/D77562
More information about the llvm-commits
mailing list