[PATCH] D77260: Clean up usages of asserting vector getters in Type

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 09:12:03 PDT 2020


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM with nit addressed.



================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:987
+          Constant::getNullValue(
+              cast<VectorType>(Src->getType())->getElementType()),
+          Src);
----------------
nit: Given that Src is always of VectorType, maybe just create a new variable
```auto *SrcTy = cast<VectorType>(Src->getType())```
that would remove the need for the `cast` here and below..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77260/new/

https://reviews.llvm.org/D77260





More information about the llvm-commits mailing list