[PATCH] D73228: [AsmPrinter][ELF] Define local aliases (.Lfoo$local) for GlobalObjects

[Ayman Musa via Phabricator via llvm-commits]

aymanmus added a comment.

Hi @MaskRay,

This change has broke the update_llc_test_checks.py tool's functionality for any test that includes a local function.
The tool now removes all "; CHECK" lines from such tests and emits nothing instead.
You can check this by adding "dso_local" attribute to any of the X86 existing tests (for example /llvm/CodeGen/X86/add-i64.ll) and run "update_llc_test_checks.py on it.

I think that it's crucial to fix this (hint: the regex strings defined at the beginning of llvm-org/llvm/utils/UpdateTestChecks/asm.py don't capture these test cases anymore).

Thanks,
Ayman


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73228/new/

https://reviews.llvm.org/D73228