[PATCH] D77511: [RDA] Avoid full reprocessing of blocks in loops (NFCI)

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 08:06:18 PDT 2020


samparker added inline comments.


================
Comment at: lib/CodeGen/ReachingDefAnalysis.cpp:157
+      int Def = Incoming[Unit];
+      if (Def != ReachingDefDefaultVal) {
+        auto Start = MBBReachingDefs[MBBNumber][Unit].begin();
----------------
It would be nice to reduce the indentation and just continue on the inverse. And maybe also continue when MBBReachingDefs[MBBNumber][Unit] is empty instead of comparing iterators below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77511/new/

https://reviews.llvm.org/D77511





More information about the llvm-commits mailing list